@geisi Could you take a look? Removing the requirement for an extra from would simplify our configuration.

@spawnia

Thanks for submitting this PR!

I understand the goal of reducing redundancy by relying on global mail.from setting, I can't merge this change.

Removing this configuration requirement, even if falling back to the global default, is a breaking change. It would break setups for existing users who have configured the from address specifically for this mailer as currently required. We need to maintain backward compatibility within the current version line.

We might revisit this as an optional setting in a future major version, but we must keep the explicit configuration for now.

Thanks again for your contribution and understanding!

I don't see how removing the requirement for explicit configuration is a breaking change. Overriding the global default is still possible, just not necessary anymore. I only removed a single line of productive code that checks for the existence of the explicit setting, not any code that would use it.

Should I make it more apparent by adding an explicit test to show how from can be overridden? And perhaps mention in the README how both options are possible?